Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds explicit 404 handling to provider error responses and simplifies error handling logic across multiple providers by consolidating duplicate code into the centralized handle_status_openai_compat function.
- Adds dedicated 404 handling with clear "Resource not found" messages
- Simplifies error message extraction with a reusable
extract_message()closure - Removes duplicate error handling code from OpenAI, Ollama, Anthropic, and Tetrate providers
- Removes unused
OpenAIErrorResponsestruct andformat_server_error_messagefunction
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| crates/goose/src/providers/utils.rs | Adds 404 handling, introduces extract_message() closure for consistent error message extraction, simplifies map_http_error_to_provider_error, streamlines handle_status_openai_compat, removes dead code and outdated test |
| crates/goose/src/providers/openai.rs | Removes duplicate error handling, delegates to handle_status_openai_compat |
| crates/goose/src/providers/ollama.rs | Removes duplicate error handling, delegates to handle_status_openai_compat |
| crates/goose/src/providers/anthropic.rs | Imports and uses handle_status_openai_compat for error handling |
| crates/goose/src/providers/tetrate.rs | Renames variable from response to resp for clarity before error handling |
jamadeo
approved these changes
Nov 18, 2025
added 3 commits
November 18, 2025 13:15
michaelneale
added a commit
that referenced
this pull request
Nov 24, 2025
* main: (48 commits) [fix] generic check for gemini compat (#5842) Add scheduler to diagnostics (#5849) Cors and token (#5850) fix sessions coming back with empty messages (#5841) markdown export from URL (#5830) Next camp refactor live (#5706) Add out of context compaction test via error proxy (#5805) fix: Add backward compatibility for conversationCompacted message type (#5819) Add /agent/stop endpoint, make max active agents configurable (#5826) Handle 404s (#5791) Persist provider name and model config in the session (#5419) Comment out the flaky mcp callers (#5827) Slash commands (#5718) fix: remove setx calls to not permanently edit the windows shell PATH (#5821) fix: Parse maas models for gcp vertex provider (#5816) fix: support Gemini 3's thought signatures (#5806) chore: Add Adrian Cole to Maintainers (#5815) [MCP-UI] Proxy and Better Message Handling (#5487) Release 1.15.0 Document New Window menu in macOS dock (#5811) ...
kskarthik
pushed a commit
to kskarthik/goose
that referenced
this pull request
Nov 26, 2025
Co-authored-by: Douwe Osinga <douwe@squareup.com> Signed-off-by: Sai Karthik <kskarthik@disroot.org>
BlairAllan
pushed a commit
to BlairAllan/goose
that referenced
this pull request
Nov 29, 2025
Co-authored-by: Douwe Osinga <douwe@squareup.com> Signed-off-by: Blair Allan <Blairallan@icloud.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Handles 404s instead of just saying 404:
now:
before:
also cleans up general error handling